-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fan 2019 ctsm #767
Draft
juliusvira
wants to merge
209
commits into
ESCOMP:master
Choose a base branch
from
juliusvira:fan-2019-ctsm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fan 2019 ctsm #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created the n05 tag
…rding to the correct unit
… fan-clm5-cpl-poolmods
…e, internally it can be ignored
…pies, as well as properly adjusting g index by begg
…ests fail for nag
@ekluzek now that you've created a branch tag for this PR, does it remain open? |
I think we leave it open as a reminder that we eventually want to bring it into main CTSM. But as we have plenty of open PRs we could close it for now. Let's talk about this Thursday. |
as with #2290, it seems like this won't make the cut for CLM6. Removing this PR from the highlight board. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
new capability or improved behavior of existing capability
priority: low
Background task that doesn't need to be done right away.
science
Enhancement to or bug impacting science
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Includes the FANv2 (Flow of Agricultural Nitrogen) process model for simulating ammonia volatilization from fertilizers and manure.
Specific notes
Are answers expected to change (and if so in what way)?
Connecting FAN to the CLM biogeochemistry (nitrogen pools) can be toggled from namelist. If not connected, answers should not change. If connected, C and N cycling will change.
Any User Interface Changes (namelist or namelist defaults changes)?
Added FAN namelist with some options and path to the FAN stream file.
Testing performed, if any:
The model has been tested with a 3-year (2009-2011) transient run for the following:
Scientific evaluation of the biogeochemistry coupling is to be done.
Other remarks:
Edit: link to slides comparing various FAN coupling options:
https://drive.google.com/file/d/1CROPPXphlwhWCMbLKl_RKUaaSehUomHg/view?usp=sharing