DO NOT MERGE - testing with various sphinx versions see if rtd theme works well #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gonna test with unpinning both sphinx and rtd_theme, and try the workaround suggested in readthedocs/sphinx_rtd_theme#1451 (comment) before I close this for good |
|
build works well and results in functional pages, will take this upstream |
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a test PR to trigger docs builds on RTD with various sphinx versions, see which one is causing the Search not working issue - need this for communication/debugging at readthedocs/sphinx_rtd_theme#1451
EDIT: testing no longer needed, problem found and explained in readthedocs/sphinx_rtd_theme#1451 (comment)