Adding a few unit tests for the EvseV2G module #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebaLukas
requested review from
corneliusclaussen,
james-ctc,
Pietfried and
hikinggrass
as code owners
james-ctc
approved these changes
Jan 21, 2025
…a starting point for further tests: - First din_server unit test prototype - adds handle_din_contract_authentication tests - adds handle_din_contract_authentication tests - fix: added missing functions to module adapter stub - Declaring exiDocument, v2g_connection & v2g_context as test class members and adding them to SetUp(). Adding some potential test cases for session setup. Adding a first not complete din service discovery test - feat: added collecting logs for EvseV2G tests for unit tests - fix: EvseV2G test now uses unique pointer to ensure clean structures for every test - Updating and adding session_setup state test - feat: added first testcases for din_validate_response_code - din_validate_response_code_DIN_tests - feat: added remainig testcases for din_validate_response_code - fix: created a quiet module adapter stub, fix: removed TODO that has been addressed, feat: added some tests around v2g_context - feat: add test file for sdp - Adding first sdp write header test Signed-off-by: Sebastian Lukas <[email protected]> Co-authored-by: MarzellT <[email protected]> Co-authored-by: James Chapman <[email protected]> Co-authored-by: Anton Kadelbach <[email protected]>
SebaLukas
force-pushed
the
feat/evsev2g_testing
branch
from
fcc1da9 to
326434b
Compare
hikinggrass
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adding a few unit tests for the EvseV2G module. This should serve as a starting point for further tests.
Issue ticket number and link
The EvseV2G module has hardly any unit tests. Nevertheless, it should be possible to test certain parts of the code, such as the DIN/ISO-2 state machine, using unit tests. The first task was to find out how easy or difficult it is to add unit tests for the DIN state machine.
Checklist before requesting a review