Feature/energymanagement unit tests #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
requested review from
Pietfried and
hikinggrass
as code owners
corneliusclaussen
force-pushed
the
feature/energymanagement-unit-tests
branch
2 times, most recently
from
b0ab335 to
084c801
Compare
Pietfried
approved these changes
Jan 22, 2025
corneliusclaussen
force-pushed
the
feature/energymanagement-unit-tests
branch
from
084c801 to
e00f7d6
Compare
hikinggrass
reviewed
Jan 22, 2025
There was a problem hiding this comment.
should this file end with " copy.json" (including the space?)
There was a problem hiding this comment.
The JSONs will be entirely rewritten in PR1033 again, so leaving as is for now
hikinggrass
reviewed
Jan 22, 2025
There was a problem hiding this comment.
should this file end with " copy.json" (including the space?)
hikinggrass
reviewed
Jan 22, 2025
| return optimized_values; | ||
| } | ||
|
|
||
| } // namespace module |
There was a problem hiding this comment.
missing newline, in general the new json files are missing a newline at the end as well
Essentially input and expected output of the run_optimizer function can be specified in a single JSON file. One unit test per file will programmatically be added to compare the output with the expected output and show a JSON diff if the test fails. Several new test cases are added and the previous C++ based unit tests are converted to JSON. Signed-off-by: Cornelius Claussen <[email protected]> Signed-off-by: Andreas Heinrich <[email protected]> Signed-off-by: Piet Gömpel <[email protected]>
corneliusclaussen
force-pushed
the
feature/energymanagement-unit-tests
branch
from
e00f7d6 to
f8e39de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR introduces new JSON based tests for EnergyManager.
Essentially input and expected output of the run_optimizer function can be specified in a single JSON file.
One unit test per file will programmatically be added to compare the output with the expected output and show a JSON diff if the test fails.
Several new test cases are added and the previous C++ based unit tests are converted to JSON.
Issue ticket number and link
Checklist before requesting a review