API: Improve error handling for command parsing #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the command was not ignored as described in the log message. Signed-off-by: Fabian Hartung <[email protected]>
FaHaGit
requested review from
hikinggrass,
Pietfried and
corneliusclaussen
as code owners
hikinggrass
approved these changes
Jan 22, 2025
barsnick
reviewed
Jan 27, 2025
hikinggrass
added
the
include-in-release
As suggested in review Signed-off-by: barsnick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Previously, if the parsing of the argument failed, the argument was not ignored as described in the log message, but processed further.
Issue ticket number and link
Checklist before requesting a review