-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS file #1041
Update CODEOWNERS file #1041
Conversation
* add @andistorm to ci related files * add @andistorm to cmake related files * add @andistorm to ErrorHistory and error example modules * add '/' to a couple of paths Signed-off-by: Andreas Heinrich <[email protected]>
The folders: https://github.com/EVerest/everest-core/tree/main/config Are most of the time modified when integrating for example a new library version (libocpp, libevsesecurity, libiso), and at the moment any small change in those files require waiting on one of the generic code owners. Also a small requirement added to a module in a config, also waits on the generic code owners. A bit more flexibility on those files that are modified quite often should be beneficial for faster merges. |
Signed-off-by: Andreas Heinrich <[email protected]>
Just had a quick look on who commited things there and added those people |
Looks a lot better for those frequently-modified files! Any thoughts @hikinggrass @corneliusclaussen @hikinggrass ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Andreas Heinrich <[email protected]>
Describe your changes
add @andistorm to ci related files
add @andistorm to cmake related files
add @andistorm to ErrorHistory and error example modules
add '/' to a couple of paths
Issue ticket number and link
Checklist before requesting a review