Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS file #1041

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Update CODEOWNERS file #1041

merged 4 commits into from
Feb 4, 2025

Conversation

andistorm
Copy link
Contributor

Describe your changes

  • add @andistorm to ci related files

  • add @andistorm to cmake related files

  • add @andistorm to ErrorHistory and error example modules

  • add '/' to a couple of paths

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

* add @andistorm to ci related files
* add @andistorm to cmake related files
* add @andistorm to ErrorHistory and error example modules

* add '/' to a couple of paths

Signed-off-by: Andreas Heinrich <[email protected]>
@AssemblyJohn
Copy link
Contributor

The folders: https://github.com/EVerest/everest-core/tree/main/config
And the file: https://github.com/EVerest/everest-core/blob/main/dependencies.yaml

Are most of the time modified when integrating for example a new library version (libocpp, libevsesecurity, libiso), and at the moment any small change in those files require waiting on one of the generic code owners. Also a small requirement added to a module in a config, also waits on the generic code owners.

A bit more flexibility on those files that are modified quite often should be beneficial for faster merges.

Signed-off-by: Andreas Heinrich <[email protected]>
@andistorm
Copy link
Contributor Author

The folders: https://github.com/EVerest/everest-core/tree/main/config And the file: https://github.com/EVerest/everest-core/blob/main/dependencies.yaml

Are most of the time modified when integrating for example a new library version (libocpp, libevsesecurity, libiso), and at the moment any small change in those files require waiting on one of the generic code owners. Also a small requirement added to a module in a config, also waits on the generic code owners.

A bit more flexibility on those files that are modified quite often should be beneficial for faster merges.

Just had a quick look on who commited things there and added those people

@AssemblyJohn
Copy link
Contributor

AssemblyJohn commented Feb 4, 2025

Looks a lot better for those frequently-modified files! Any thoughts @hikinggrass @corneliusclaussen @hikinggrass ?

Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andistorm andistorm merged commit 6f0f253 into main Feb 4, 2025
12 checks passed
@andistorm andistorm deleted the feature/update-codeowners-file branch February 4, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants