PhyVersoBSP: Implemented request_stop_transaction via external push buttons connected to SOM GPIOs #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rckstrh
requested review from
Pietfried,
hikinggrass,
corneliusclaussen,
SirVer,
golovasteek and
dorezyuk
as code owners
golovasteek
approved these changes
Jul 24, 2024
rckstrh
force-pushed
the
driver/phyverso-bsp-hw-rev1
branch
from
26bcd5a to
cd73733
Compare
rckstrh
requested review from
SebaLukas,
maaikez,
james-ctc,
AssemblyJohn and
a-w50
as code owners
rckstrh
force-pushed
the
driver/phyverso-bsp-hw-rev1
branch
from
cd73733 to
26bcd5a
Compare
corneliusclaussen
approved these changes
Aug 2, 2024
corneliusclaussen
force-pushed
the
driver/phyverso-bsp-hw-rev1
branch
from
4056b10 to
4b3ece0
Compare
rcd_1 and rcd_2 raise ac_rcd errors instead of EVLOG_info printing Implemented request_stop_transaction on external push buttons connected to SOM GPIOs * Connector 1 and 2 can be configured to use external connected push buttons to request stop transaction * Push buttons need external pull resistors * request_stop_transaction functionality disabled by default because inputs would be floating as PhyVerso has no pull resistors on board * GPIO pin number and bank can be configured, by default connector 1 uses IN_1 (X43 pin 5) and connector 2 uses IN_2 (X43 pin 7); 5V tolerant inputs * button logic levels can be inverted in EVerest config Signed-off-by: Jonas Rockstroh <[email protected]>
corneliusclaussen
force-pushed
the
driver/phyverso-bsp-hw-rev1
branch
from
4b3ece0 to
93d11a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
These changes were implemented to be able to request a stop of a charging session by applying a digital signal to one of the 5V tolerant buffered SOM inputs. GPIO banks/pins as well as signal polarity are configurable via EVerest config parameters. The request_stop_transaction functionality via GPIO is by default disabled because input pins are floating due to missing pull resistors on phyVERSO HW revision 1. The GPIO inputs are getting debounced in software with currently ~160ms duration needed to register a stable state.
Issue ticket number and link
Checklist before requesting a review