Extending 1ph/3ph feature #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
requested review from
SebaLukas,
hikinggrass and
Pietfried
as code owners
hikinggrass
requested changes
Aug 1, 2024
SebaLukas
approved these changes
Aug 1, 2024
corneliusclaussen
force-pushed
the
feature/switch_1ph_3ph_extensions
branch
2 times, most recently
from
76d0bff to
3ec43c6
Compare
corneliusclaussen
force-pushed
the
feature/switch_1ph_3ph_extensions
branch
from
12d095c to
2a5b70b
Compare
|
@hikinggrass I addressed all your comments |
hikinggrass
approved these changes
Sep 4, 2024
corneliusclaussen
force-pushed
the
feature/switch_1ph_3ph_extensions
branch
from
2a5b70b to
2e113c1
Compare
Adds the following config options: - Power (watt) hysteresis - Time based hysteresis for switching to 3ph - Max number of switching cycles per session - Stickyness (aka what happens if max switching cycles are reached) Signed-off-by: Cornelius Claussen <[email protected]>
Signed-off-by: Cornelius Claussen <[email protected]>
Signed-off-by: Cornelius Claussen <[email protected]>
Signed-off-by: Cornelius Claussen <[email protected]>
corneliusclaussen
force-pushed
the
feature/switch_1ph_3ph_extensions
branch
from
2e113c1 to
f7949b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following config options:
Describe your changes
Issue ticket number and link
Checklist before requesting a review