Registered time_sync_callback in OCPP201 module #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pietfried <[email protected]>
a-w50
reviewed
Aug 5, 2024
| @@ -529,6 +529,10 @@ void OCPP201::ready() { | |||
| return; | |||
| }; | |||
|
|
|||
| callbacks.time_sync_callback = [this](const ocpp::DateTime& current_time) { | |||
There was a problem hiding this comment.
Instead of capturing everything (i.e. this), it is advised to capture only the things that are needed. So you could probably also write:
callbacks.time_sync_callback = [&system = this->r_system](const auto& current_time) {
system->call_set_system_time(current_time.to_rfc3339());
}
But note, that this would not be the same in case this->r_system changes during the lifetime of the assigned function.
There was a problem hiding this comment.
Right, since this covers almost every other callback definition, I have raised an issue for that: #828 . It therefore won't be covered as part of this PR.
hikinggrass
approved these changes
Aug 13, 2024
barsnick
added a commit
to chargebyte/meta-chargebyte-everest
that referenced
this pull request
Aug 15, 2024
This adds a patch from a PR which is not yet part of a release (currently referencing 2024.7.1): - PR EVerest/everest-core#814 "Registered time_sync_callback in OCPP201 module" Signed-off-by: Moritz Barsnick <[email protected]>
barsnick
added a commit
to chargebyte/meta-chargebyte-everest
that referenced
this pull request
Sep 10, 2024
This adds a patch from a PR which is not yet part of a release (currently referencing 2024.7.1): - PR EVerest/everest-core#814 "Registered time_sync_callback in OCPP201 module" Signed-off-by: Moritz Barsnick <[email protected]>
barsnick
added a commit
to chargebyte/meta-chargebyte-everest
that referenced
this pull request
Sep 12, 2024
This adds a patch from a PR which is not yet part of a release (currently referencing 2024.8.0): - PR EVerest/everest-core#814 "Registered time_sync_callback in OCPP201 module" Signed-off-by: Moritz Barsnick <[email protected]>
barsnick
added a commit
to chargebyte/meta-chargebyte-everest
that referenced
this pull request
Sep 12, 2024
This adds a patch from a PR which is not yet part of a release (currently referencing 2024.8.0): - PR EVerest/everest-core#814 "Registered time_sync_callback in OCPP201 module" Signed-off-by: Moritz Barsnick <[email protected]>
barsnick
added a commit
to chargebyte/meta-chargebyte-everest
that referenced
this pull request
Sep 12, 2024
This adds a patch from a PR which is not yet part of a release (currently referencing 2024.8.0): - PR EVerest/everest-core#814 "Registered time_sync_callback in OCPP201 module" Signed-off-by: Moritz Barsnick <[email protected]>
barsnick
added a commit
to chargebyte/meta-chargebyte-everest
that referenced
this pull request
Sep 17, 2024
This adds a patch from a PR which is not yet part of a release (currently referencing 2024.8.0): - PR EVerest/everest-core#814 "Registered time_sync_callback in OCPP201 module" Signed-off-by: Moritz Barsnick <[email protected]>
barsnick
added a commit
to chargebyte/meta-chargebyte-everest
that referenced
this pull request
Sep 18, 2024
This adds a patch from a PR which is not yet part of a release (currently referencing 2024.8.0): - PR EVerest/everest-core#814 "Registered time_sync_callback in OCPP201 module" Signed-off-by: Moritz Barsnick <[email protected]>
…allback-v201 # Conflicts: # modules/OCPP201/OCPP201.cpp
hikinggrass
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review