EvseSlac: Fix regression that NMK was not regenerated on reset #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cornelius Claussen <[email protected]>
|
Verfied on real HW that it now generates new NMK keys for each session. Also verfied it only sends one set_key.req at startup and not two. |
|
Despite no code change, CM_SET_KEY.REQ is only sent once? |
a-w50
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Just a note (I know I initially wrote this), but the generate_nmk function should be a free function and the code should look like
ctx.slac_config.session_nmk = generate_nmk() this is more explicit. Unfortunately standard c arrays are not copyable like this, but this can be mitigated by using std::array which would also be more safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
A regression had been introduced between 2024.2.0 and 2024.3.0 that removed the re-generation of the NMK in between sessions. This PR re-adds this functionality.
Issue ticket number and link
Checklist before requesting a review