Fix legacy wakeup for PWM charging #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
requested review from
SebaLukas,
hikinggrass and
Pietfried
as code owners
hikinggrass
reviewed
Sep 5, 2024
| @@ -372,6 +375,7 @@ void IECStateMachine::set_pwm_F() { | |||
|
|
|||
| // The higher level state machine in Charger.cpp calls this to indicate it allows contactors to be switched on | |||
| void IECStateMachine::allow_power_on(bool value, types::evse_board_support::Reason reason) { | |||
| EVLOG_info << "Allow power on: " << value << " Reason: " << reason; | |||
There was a problem hiding this comment.
Is that log message desired here or left over from debugging?
There was a problem hiding this comment.
It is desired
Signed-off-by: Cornelius Claussen <[email protected]>
corneliusclaussen
force-pushed
the
bugfix/fix-legacy-wakeup
branch
from
410288c to
13e7a1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Resuming charging after legacy wakeup sequence did not work since no allow_power_on(true) was sent to the BSP in this case. This PR fixes this issue.
Issue ticket number and link
Checklist before requesting a review