Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EvManager: Move subscribe_to_external_mqtt to ready() #855

Merged
merged 3 commits into from
Sep 5, 2024
Merged

EvManager: Move subscribe_to_external_mqtt to ready() #855

merged 3 commits into from
Sep 5, 2024

Conversation

hikinggrass
Copy link
Contributor

@hikinggrass hikinggrass commented Sep 5, 2024 •
edited
Loading

This avoids problems with potentially triggering enable too early which could happen when using the external mqtt api

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

SebaLukas
SebaLukas approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 maybe delete this->

@SebaLukas
Copy link
Contributor

Other suggestion: Move subscribe_to_external_mqtt(); from car_simulatorImpl::init() to car_simulatorImpl::ready()

@hikinggrass
Copy link
Contributor Author

Other suggestion: Move subscribe_to_external_mqtt(); from car_simulatorImpl::init() to car_simulatorImpl::ready()

I'll try that and will update this PR

@hikinggrass hikinggrass changed the title EvManager: ignore enable if it arrives before ready EvManager: Move subscribe_to_external_mqtt to ready() Sep 5, 2024
SebaLukas
SebaLukas approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hikinggrass @corneliusclaussen
EvManager: ignore enable if it arrives before ready
2c9afc8 
This can happen when using the external mqtt api

Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass @corneliusclaussen
remove this->
8ff4f2a 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass @corneliusclaussen
EvManager: Move subscribe_to_external_mqtt to ready()
c6ff9d9 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@corneliusclaussen corneliusclaussen force-pushed the bugfix/evmanager-ignore-enable branch from eb56882 to c6ff9d9 Compare September 5, 2024 14:35
@hikinggrass hikinggrass merged commit 8676d43 into main Sep 5, 2024
11 checks passed
@hikinggrass hikinggrass deleted the bugfix/evmanager-ignore-enable branch September 5, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebaLukas SebaLukas SebaLukas approved these changes

@Pietfried Pietfried Awaiting requested review from Pietfried Pietfried is a code owner

@MarzellT MarzellT Awaiting requested review from MarzellT MarzellT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hikinggrass @SebaLukas