Adding Slac Simulator #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarzellT
force-pushed
the
tm-adding-slacsimulator
branch
2 times, most recently
from
7af19b6 to
d33928d
Compare
MarzellT
requested review from
Pietfried,
hikinggrass and
corneliusclaussen
as code owners
|
Maybe add the SlacSimulator to the CodeOwner file and add you, me and Cornelius for this module |
3 tasks
MarzellT
force-pushed
the
tm-adding-slacsimulator
branch
3 times, most recently
from
1e3b18f to
0887bd3
Compare
Signed-off-by: MarzellT <[email protected]>
Signed-off-by: MarzellT <[email protected]>
Signed-off-by: MarzellT <[email protected]>
MarzellT
force-pushed
the
tm-adding-slacsimulator
branch
from
0887bd3 to
b0a8e50
Compare
hikinggrass
requested changes
Sep 12, 2024
Signed-off-by: MarzellT <[email protected]>
MarzellT
force-pushed
the
tm-adding-slacsimulator
branch
from
6687536 to
8ae04f6
Compare
Signed-off-by: MarzellT <[email protected]>
Signed-off-by: MarzellT <[email protected]>
SebaLukas
requested changes
Sep 12, 2024
Signed-off-by: MarzellT <[email protected]>
Signed-off-by: MarzellT <[email protected]>
Signed-off-by: MarzellT <[email protected]>
SebaLukas
approved these changes
Sep 13, 2024
… initialized early enough Otherwise publishes from other modules can happen before its initialization triggering segfaults Signed-off-by: Kai-Uwe Hermann <[email protected]>
SebaLukas
reviewed
Sep 16, 2024
hikinggrass
approved these changes
Sep 17, 2024
corneliusclaussen
requested changes
Sep 24, 2024
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
corneliusclaussen
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This module implements a C++ rewrite for the JsSlacSimulator
Issue ticket number and link
Checklist before requesting a review