Make correct phase count available in API #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The available phase count is part of the type "evse_manager::limits". This type is published via mqtt and is used by the API module to interact with external software stacks like Nymea. Per default the available phase count is set to value 1, during the init of the evse_manager interface. The EvseManager determines the count of active phases with help of the min and max phase count values as part of the type "evse_board_support::HardwareCapabilities". This is published by other modules like CbTarragonDriver. But this value is never published via "limits" topic through API module. This leads to wrong values in the Nymea App. Although 3 phases are connected to wallbox, only 1 phase is used for energy management. This commit should fix this. Signed-off-by: Martin Lukas <[email protected]>
martinlukas84
requested review from
corneliusclaussen,
SebaLukas,
hikinggrass and
Pietfried
as code owners
corneliusclaussen
approved these changes
Sep 25, 2024
hikinggrass
added
the
include-in-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The available phase count is part of the type "evse_manager::limits". This type is published via mqtt and is used by the API module to interact with external software stacks like Nymea.
Per default the available phase count is set to value 1, during the init of the evse_manager interface. The EvseManager determines the count of active phases with help of the min and max phase count values as part of the type "evse_board_support::HardwareCapabilities". This is published by other modules like CbTarragonDriver.
But this value is never published via "limits" topic through API module. This leads to wrong values in the Nymea App. Although 3 phases are connected to wallbox, only 1 phase is used for energy management. This commit should fix this.
Describe your changes
Issue ticket number and link
Checklist before requesting a review