refactor(EvseManager): use std::optional instead of pair #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-w50
requested review from
corneliusclaussen,
SebaLukas,
hikinggrass and
Pietfried
as code owners
|
Also have a look at this branch. Although its implementation is more complex, it scales better and should be less error prone. |
corneliusclaussen
approved these changes
Oct 1, 2024
corneliusclaussen
force-pushed
the
refactor/simplify_evse_manager_error_handling
branch
from
ad0b375 to
d863e62
Compare
Signed-off-by: aw <[email protected]>
corneliusclaussen
force-pushed
the
refactor/simplify_evse_manager_error_handling
branch
from
d863e62 to
df30a6f
Compare
corneliusclaussen
deleted the
refactor/simplify_evse_manager_error_handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review