Fix(EvseV2G): Deleting an unnecessary reset when the contract chain certificates are validated locally #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebaLukas
requested review from
corneliusclaussen and
james-ctc
as code owners
|
LGTM |
Signed-off-by: Sebastian Lukas <[email protected]>
…ails fails Signed-off-by: Sebastian Lukas <[email protected]>
SebaLukas
force-pushed
the
fix/iso_2-payment-details
branch
from
07b22f8 to
c23947a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Deleting the payement_details_res reset and adding better handling if the local verification of the contract chain certs fails
Issue ticket number and link
If the local contract chain certs verification with a
NoCertificateAvailableerror failed, the payment_details_res was resetted. This is not correct.If the local contract chain certs verification generally failed, then the code does not go to
error_out.Checklist before requesting a review