Introduce RequestCompositeScheduleUnit argument in OCPP module #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
changed the title
Pietfried
requested review from
hikinggrass,
maaikez and
corneliusclaussen
as code owners
corneliusclaussen
force-pushed
the
bugfix/phase-switching-ac
branch
from
ae9a557 to
b9dfdf4
Compare
Pietfried
force-pushed
the
bugfix/phase-switching-ac
branch
from
b9dfdf4 to
10447b4
Compare
Pietfried
added
the
include-in-release
Pietfried
commented
Oct 18, 2024
hikinggrass
approved these changes
Oct 18, 2024
Signed-off-by: Piet Gömpel <[email protected]>
…t when requesting composite schedules Signed-off-by: Piet Gömpel <[email protected]>
Signed-off-by: Piet Gömpel <[email protected]>
Signed-off-by: Cornelius Claussen <[email protected]>
Signed-off-by: Piet Gömpel <[email protected]>
Pietfried
force-pushed
the
bugfix/phase-switching-ac
branch
from
f9c2689 to
8b6ffd9
Compare
This reverts commit eea3ddd. Signed-off-by: Piet Gömpel <[email protected]>
Pietfried
force-pushed
the
bugfix/phase-switching-ac
branch
from
8b6ffd9 to
48cc6af
Compare
hikinggrass
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Set numberPhases also for Watt Unit in OCPP * Added parameter RequestCompositeScheduleUnit for OCPP module to use it when requesting composite schedules --------- Signed-off-by: Piet Gömpel <[email protected]> Signed-off-by: Cornelius Claussen <[email protected]> Signed-off-by: Piet Gömpel <[email protected]> Co-authored-by: Cornelius Claussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Libocpp so far had always reported composite schedules using the ChargingRateUnit::A (amps). This is now configurable with this PR, allowing to specify the unit as an argument.
This PR introduces the
RequestCompositeScheduleUnitas an argument in the OCPP module, which is then used when requesting the composite schedule. The same was already done for the OCPP201 module.Additionally, this PR also sets the
ac_max_phase_countfor DC schedules, to allow phase switching in the Energymanagement. It was only set for AC schedules so far.TODOs
* Update libocpp dependency once EVerest/libocpp#834 is merged.* Update module documentation pointing to this parameter: Will be done as part of #908Issue ticket number and link
Checklist before requesting a review