Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug which interchanged number phases and stack level when conve… #929

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

Pietfried
Copy link
Contributor

@Pietfried Pietfried commented Oct 24, 2024

…rting from OCPP to everest ChargingSchedulePeriod type

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

…rting from OCPP to everest ChargingSchedulePeriod type

Signed-off-by: Piet Gömpel <[email protected]>
@Pietfried Pietfried added the include-in-release Tag that this PR should be included in the current merge window for the upcoming release if possible label Oct 24, 2024
@Pietfried Pietfried requested a review from james-ctc October 24, 2024 09:28
@Pietfried Pietfried added the bug Something isn't working label Oct 24, 2024
Copy link
Contributor

@a-w50 a-w50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would still use csp instead of _period.

@Pietfried Pietfried force-pushed the bugfix/interchanged-stacklevel-and-numberphases branch from 8b4c7b7 to 856bc35 Compare October 24, 2024 10:18
@Pietfried Pietfried merged commit d2a087e into main Oct 24, 2024
10 checks passed
@Pietfried Pietfried deleted the bugfix/interchanged-stacklevel-and-numberphases branch October 24, 2024 11:51
hikinggrass pushed a commit that referenced this pull request Oct 25, 2024
#929)

* Fixed bug which interchanged number phases and stack level when converting from OCPP to everest ChargingSchedulePeriod type
---------

Signed-off-by: Piet Gömpel <[email protected]>
Signed-off-by: Piet Gömpel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working include-in-release Tag that this PR should be included in the current merge window for the upcoming release if possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants