Slac: avoid second chip reset if it was already performed before unplug #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
requested review from
SebaLukas,
hikinggrass and
Pietfried
as code owners
a-w50
approved these changes
Nov 12, 2024
Signed-off-by: Cornelius Claussen <[email protected]>
Pietfried
force-pushed
the
bugfix/slac_second_reset
branch
from
24d3b9a to
22b9e7d
Compare
Pietfried
pushed a commit
that referenced
this pull request
Dec 16, 2024
…ug (#955) Signed-off-by: Cornelius Claussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
On unplug, slac was reset every time. Slac also needs to be reset whenever the iso session ends, leading to an unneccessary reset if the unplug happens directly after the session end (with no resumed charging etc)
Issue ticket number and link
Checklist before requesting a review