Always try to unlock the Connector, as long as the relays are not on #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 13, 2024 16:15
…always lock with open relays. Signed-off-by: Yonatan Dankner <[email protected]>
Signed-off-by: Yonatan Dankner <[email protected]>
ydankner
requested review from
corneliusclaussen,
SebaLukas,
hikinggrass and
Pietfried
as code owners
ydankner
force-pushed
the
feat/force_unlock_fixes
branch
from
2952afc to
3d0468e
Compare
ydankner
commented
Nov 21, 2024
|
@ydankner The word "Contactor" in the pull request subject is confusing. Is it possible you meant "connector" or "plug lock"? |
ydankner
changed the title
Yes, thanks :) |
corneliusclaussen
approved these changes
Dec 2, 2024
hikinggrass
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This is a followup to a previous attempt. The idea is the
is_lockedvariable and the physical lock might be out of sync. In this MR I'm trying to unconditionally unlock the lock, as long as the relays are open.Additionally, I'm ensuring that we always lock in
check_connector_lockif the relays are on.Issue ticket number and link
Checklist before requesting a review