-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added features to EvseV2G doc.rst #964
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
barsnick
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct. One typo though.
(Do also note the Codacy line length "issue".)
Signed-off-by: Sebastian Lukas <[email protected]>
barsnick
requested changes
Dec 9, 2024
Signed-off-by: Sebastian Lukas <[email protected]>
barsnick
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an RST parser. :D
Otherwise LGTM.
Pietfried
approved these changes
Dec 26, 2024
james-ctc
approved these changes
Jan 9, 2025
Pietfried
pushed a commit
that referenced
this pull request
Jan 15, 2025
* Added DIN70121 and ISO15118-2 feature lists --------- Signed-off-by: Sebastian Lukas <[email protected]> Co-authored-by: Piet Gömpel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adding a features.md. This document contains two feature lists to show the current DIN70121 and ISO15118-2 support.
Issue ticket number and link
Without a feature list, it is quite difficult to get an overview of which DIN70121 and ISO15118-2 features EvseV2G already supports.
Checklist before requesting a review