RsIskraMeter: Report error on consistent meter communication failure #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wku12
requested review from
SirVer,
dorezyuk,
Pietfried,
hikinggrass and
corneliusclaussen
as code owners
|
@wku12 can you please remove the reviewers until this is ready for review? |
I think developers listed in the CODEOWNERS are automatically requested and cannot be removed afterwards but as long as PRs are in draft, we know its not yet ready for review. |
wku12
force-pushed
the
feat/rs_iskra_meter_errors
branch
from
5ec79b2 to
610e160
Compare
wku12
changed the title
|
@SirVer @Pietfried It's ready for review now - I rebased with the everest-framework bump you have done |
wku12
force-pushed
the
feat/rs_iskra_meter_errors
branch
2 times, most recently
from
1bfa959 to
1577c64
Compare
dorezyuk
approved these changes
Dec 12, 2024
Signed-off-by: Wojciech Kula <[email protected]>
wku12
force-pushed
the
feat/rs_iskra_meter_errors
branch
from
1577c64 to
833a5f2
Compare
SirVer
approved these changes
Dec 13, 2024
|
@hikinggrass @Pietfried @corneliusclaussen I am not sure why you are selected as reviewers, since this does not touch on anything besides Rust stuff, but could we get a rubberstamp to satisfy GitHub, please? |
hikinggrass
approved these changes
Dec 13, 2024
corneliusclaussen
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Now when we have communication errors with RsIskraMeter we will report errors. To have it working we have to bump everest-framework, so please do not look at those changes for now.
Issue ticket number and link
Checklist before requesting a review