CableCheck: allow 0 samples, option to disable wait below 60V at end … #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
requested review from
SebaLukas,
hikinggrass and
Pietfried
as code owners
…of cablecheck Signed-off-by: Cornelius Claussen <[email protected]>
corneliusclaussen
force-pushed
the
feat/cablecheck_0samples
branch
from
2840758 to
a666078
Compare
hikinggrass
approved these changes
Dec 13, 2024
Signed-off-by: Cornelius Claussen <[email protected]>
Pietfried
pushed a commit
that referenced
this pull request
Dec 16, 2024
#990) * CableCheck: allow 0 samples, option to disable wait below 60V at end of cablecheck Signed-off-by: Cornelius Claussen <[email protected]> --------- Signed-off-by: Cornelius Claussen <[email protected]> Co-authored-by: Kai Hermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of cablecheck
Describe your changes
Issue ticket number and link
Checklist before requesting a review