PN532TokenProvider: drop unused config 'timeout' #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhei
requested review from
Pietfried,
hikinggrass and
corneliusclaussen
as code owners
Pietfried
approved these changes
Dec 17, 2024
hikinggrass
approved these changes
Jan 2, 2025
|
Hi @mhei , thanks for the PR. Please rebase your branch since it is now out of date with main so that we can merge it. |
The variable is not used anymore, so can be dropped. Signed-off-by: Michael Heimpold <[email protected]>
mhei
force-pushed
the
drop-pn532-config-timeout
branch
from
8c7048c to
bcfe4fd
Compare
|
done |
Pietfried
pushed a commit
that referenced
this pull request
Jan 15, 2025
The variable is not used anymore, so can be dropped. Signed-off-by: Michael Heimpold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The variable is not used anymore, so can be dropped.
Issue ticket number and link
Checklist before requesting a review