Skip to content

Commit

Permalink
💥 Fix crash on m3 chips by changing the arguments to the socket param…
Browse files Browse the repository at this point in the history
…eter

This fixes
#99

Testing done:
- started EVerest
    - before this fix: crashed on startup
    - after this fix: did not crash on startup

Signed-off-by: Shankari <[email protected]>
  • Loading branch information
Shankari committed Jan 15, 2025
1 parent cf31537 commit 648948c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions manager/demo-patch-scripts/apply-library-patches.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@
echo "Applying library patches"

cd / && patch -p0 -i /tmp/demo-patches/enable_ocpp_logging.patch
cd / && patch -p0 -i /tmp/demo-patches/support_m3_chip.patch
10 changes: 10 additions & 0 deletions manager/demo-patches/support_m3_chip.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
--- /ext/cache/cpm/everest-framework/d01be681d203f70289900147e87a8f4c43ff47f0/everest-framework/src/system_unix.cpp
+++ /ext/cache/cpm/everest-framework/d01be681d203f70289900147e87a8f4c43ff47f0/everest-framework/src/system_unix.cpp
@@ -190,7 +190,7 @@ std::string set_user_and_capabilities(const std::string& run_as_user, const std:
SubProcess SubProcess::create(const std::string& run_as_user, const std::vector<std::string>& capabilities) {
int pipefd[2];

- if (pipe2(pipefd, O_CLOEXEC | O_DIRECT)) {
+ if (pipe2(pipefd, O_CLOEXEC)) {
throw std::runtime_error(fmt::format("Syscall pipe2() failed ({}), exiting", strerror(errno)));
}

0 comments on commit 648948c

Please sign in to comment.