Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Departure time patches #34

Draft
wants to merge 7 commits into
base: everest
Choose a base branch
from

Conversation

Abby-Wheelis
Copy link

Describe your changes

additions of charging_session_timer, end_of_profile_schedule, sim_speed, and departure_time to the iso15118/evcc_comm_session_handler.py file to initialize these values used in the schedule calculation that includes departure time
addition of EAmount and DepartureTime to the EVState class definition
changes in iso15118/controller/simulator.py which convert hardcoded EAmount and DepartureTime with variables in the EVEREST_EV_STATE and include calculating a power curve based on the requested departure time and publishes it via mqtt
additions to iso15118/evcc/states/iso15118_2_states.py to handle the end of the charging profile

Issue ticket number and link

#220

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

Opening PR as a draft to continue the conversation about the changes.

@SebaLukas SebaLukas self-assigned this Feb 11, 2025
@SebaLukas
Copy link
Collaborator

I will have a look next week

Copy link
Collaborator

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a first look and what I immediately noticed.

  • Please do not use prints, but the log functions accordingly.
  • There must be an alternative that Josev does not publish/subscribe directly to mqtt (everest_external/nodered/..). If we allow something like that here, I can no longer guarantee that the EV sim will work. Especially with different versions of NodeRed config jsons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants