Modified hierarchy algorithm to be linear for insertion and O(n^{2}) … #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AssemblyJohn
requested review from
Pietfried
and removed request for
valentin-dimov
|
I've just encountered a endless while loop that did not have a timeout. This PR seems to fix it for me so hopefully we can merge this one soon. To reproduce, I just install a single csms root certificate in the bundle and try to delete that. On the delete ocpp hangs. |
marcemmers
reviewed
Jan 17, 2024
…worst case for pruning Signed-off-by: ioanbogdan <[email protected]>
AssemblyJohn
force-pushed
the
refactor/hierarchy_tree_operations
branch
from
44fc314 to
7f8f2cd
Compare
Pietfried
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…worst case for pruning