ci: Run tests in CI #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @shankari |
|
CC also @AssemblyJohn |
christopher-davis-afs
force-pushed
the
wip/cdavis/run-tests-in-ci
branch
from
78be9b6 to
e6c2a93
Compare
shankari
reviewed
Dec 1, 2023
christopher-davis-afs
force-pushed
the
wip/cdavis/run-tests-in-ci
branch
from
e6c2a93 to
d7cb54d
Compare
shankari
approved these changes
Dec 1, 2023
couryrr-afs
reviewed
Dec 4, 2023
christopher-davis-afs
force-pushed
the
wip/cdavis/run-tests-in-ci
branch
3 times, most recently
from
e5069e7 to
c9e0e38
Compare
christopher-davis-afs
force-pushed
the
wip/cdavis/run-tests-in-ci
branch
5 times, most recently
from
86afae8 to
ba0dfa5
Compare
|
@shankari I've made some changes to this based on the community feedback on the libocpp PR. Could you take another look at this? CC: @Dominik-K as the provider for the aforementioned community review. |
christopher-davis-afs
force-pushed
the
wip/cdavis/run-tests-in-ci
branch
from
ba0dfa5 to
70bdebe
Compare
6 tasks
|
When the pull request is ready for merging, please mark me as a reviewer. |
andistorm
requested changes
Feb 6, 2024
christopher-davis-afs
force-pushed
the
wip/cdavis/run-tests-in-ci
branch
from
70bdebe to
2efeca8
Compare
https://github.com/US-JOET/libevse-security/actions/runs/7264602730 |
Signed-off-by: Christopher Davis <[email protected]>
christopher-davis-afs
force-pushed
the
wip/cdavis/run-tests-in-ci
branch
from
2efeca8 to
524f64f
Compare
andistorm
reviewed
Feb 7, 2024
This commit changes our CI configuration to run our tests when we receive a PR. To keep consistency between libevse-security and other EVerest projects, we also handle linting within `build_and_test.yaml`. Signed-off-by: Christopher Davis <[email protected]>
christopher-davis-afs
force-pushed
the
wip/cdavis/run-tests-in-ci
branch
from
524f64f to
6b72370
Compare
andistorm
approved these changes
Feb 7, 2024
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PE changes our CI configuration to run our tests when we receive a PR.
To keep consistency between libevse-security and other EVerest projects, we also
handle linting within
build_and_test.yaml. Included is a commit to tweak the.gitignorefile so that ci changes are not ignored.One thing I noticed is that other components use ninja instead of make. Should we be using ninja here as well?