Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1. Fix the logic error of certificate_path #88

Merged
merged 1 commit into from
Aug 1, 2024
Merged

1. Fix the logic error of certificate_path #88

merged 1 commit into from
Aug 1, 2024

Conversation

Elsa-is-My-Muse
Copy link
Contributor

Describe your changes

fix_bug_get_error_path

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

AssemblyJohn
AssemblyJohn approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@AssemblyJohn AssemblyJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, caught logic error.

@AssemblyJohn AssemblyJohn merged commit d1f9a77 into EVerest:main Aug 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AssemblyJohn AssemblyJohn AssemblyJohn approved these changes

@Pietfried Pietfried Awaiting requested review from Pietfried Pietfried is a code owner

@hikinggrass hikinggrass Awaiting requested review from hikinggrass hikinggrass is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elsa-is-My-Muse @AssemblyJohn