Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified code not to presume that a multi-chain certificate is always returned #89

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

AssemblyJohn
Copy link
Collaborator

@AssemblyJohn AssemblyJohn commented Aug 1, 2024

Describe your changes

In the following PR we are not presuming that the response to a CSR by the CSMS contains the leaf + SUBCAs but it will only output the single leaf, and will output the leaf+chain only if the received list is > than 1

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

… returned by the CSMS after signing a CSR

Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn AssemblyJohn force-pushed the bugfix/fix_multi_certificate_expectation branch from 0ae7815 to dbd7b41 Compare August 5, 2024 14:07
Copy link
Collaborator

@james-ctc james-ctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@AssemblyJohn AssemblyJohn merged commit a80ea8b into main Aug 6, 2024
4 checks passed
@AssemblyJohn AssemblyJohn deleted the bugfix/fix_multi_certificate_expectation branch August 6, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants