Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requirements update #95

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Requirements update #95

merged 4 commits into from
Nov 13, 2024

Conversation

AssemblyJohn
Copy link
Collaborator

@AssemblyJohn AssemblyJohn commented Oct 29, 2024 •
edited
Loading

Describe your changes

  • Fixed typo
  • Ignores case when deleting a certificate, added functionality for case-insensitive comparison
  • Ignores any root certificates (contained in our hierarchy or self-signed) when updating the leaf

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@Pietfried Pietfried self-assigned this Nov 12, 2024
@AssemblyJohn
Updated comments
549ac8c 
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn AssemblyJohn merged commit 46f0187 into main Nov 13, 2024
2 of 3 checks passed
@AssemblyJohn AssemblyJohn deleted the requirements_update branch November 13, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pietfried Pietfried Pietfried approved these changes

@hikinggrass hikinggrass Awaiting requested review from hikinggrass hikinggrass is a code owner

Assignees

@Pietfried Pietfried

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AssemblyJohn @Pietfried