Revert to full .NET Framework MSBuild for Pack target #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n be used in Package build step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that using
dotnet packcalls MSBuild Core, doesn't allow us to call GitVersionTask because it hasn't been ported to .NET Core. As a result, the necessary GitVersion information is not propagated to the NuGet package.This PR works around this by invoking the full .NET Framework MSBuild with the pack target.
Unfortunately, this will only work with a full installation of Visual Studio 2017. It will not work on installations of Visual Studio 2017 Build Tools because the installer does not include: