-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Add GitHub Action to build, sign, release NuGet package #495
Conversation
6bb91d2
to
536d7a0
Compare
563674b
to
0f17da2
Compare
a01ad10
to
c580fe3
Compare
I will uncomment the final publish step in the GitHub Actions config once the rest of this process has been approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have various questions (most of the code looks good) so I'm blocking till those are worked through.
I think I'd like to do a release candidate for this next major release to ensure this works as we expect, that way we buy ourselves a buffer in the off chance the release goes bad. If it works we can follow it up quickly with the real release.
…in GitHub Actions-powered release process)
…use in GitHub Actions
… GitHub Actions - New GitHub Action config to automate release process on pushing to a tag
- Migrate release worker to Windows instead of Ubuntu - Remove unused Unix scripts
c580fe3
to
a371357
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will try this tomorrow for release to see if it works
6d72e54
to
845196f
Compare
845196f
to
f7d0cec
Compare
Description
Changes to how Digicert issues our authenticity certificate have accelerated our migration of the release process to a GitHub Action. This PR makes introductions and modifications necessary to build, sign and release our library via a GitHub Action.
v
, does the following:build_release_nuget
script (previously called viamake prep-release
, now called directly), which:RELEASE_NOTES.md
as the body text.NOTE: This PR checks in our entire strong-name certificate (
EasyPostNETStrongNameSigning.snk
), as this is needed for the signing process. Strong-name certificates are perfectly-safe to check into public repositories in their entirety (they are not traditional security-focused certificates). Previously, we only included the public key in this repository out of caution, but now that the whole certificate needs to be present to complete the release process, it's best to follow industry recommendations. This is easier than the alternative of encrypting/decrypting a copy of the certificate during Action time.Not currently squashing in case reference to earlier work is needed. This PR has evolved many times in its lifespan.
TODO:
Testing
Steps up to and including
build_release_nuget
were successful in testing, producing validated signed DLLs inside a validated signed NuGet package file.Pull Request Type
Please select the option(s) that are relevant to this PR.