Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prepare v5.3.0 for release #497

Merged
merged 1 commit into from
Jul 28, 2023
Merged

chore: prepare v5.3.0 for release #497

merged 1 commit into from
Jul 28, 2023

Conversation

Justintime50
Copy link
Member

Description

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team July 27, 2023 19:17
nwithan8
nwithan8 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@nwithan8 nwithan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, the only change in this version is a bug fix for Bad Request HTTP 400. HTTP hooks have already been released for this library.

I would vouch for a patch release rather than a minor release here.

@Justintime50
Copy link
Member Author

To be clear, the only change in this version is a bug fix for Bad Request HTTP 400. HTTP hooks have already been released for this library.

I would vouch for a patch release rather than a minor release here.

It's not a bug, it's a new feature (the addition) of a new error type. The library functions perfectly well without the addition so it's not a bug fix.

@Justintime50 Justintime50 merged commit c86d36f into master Jul 28, 2023
14 checks passed
@Justintime50 Justintime50 deleted the v5.3.0 branch July 28, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen293 jchen293 jchen293 approved these changes

@nwithan8 nwithan8 nwithan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Justintime50 @nwithan8 @jchen293