-
-
Notifications
You must be signed in to change notification settings - Fork 62.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Homogenize governance (CoC, CONTRIBUTING & HOWTO) across files #6590
Comments
I'll prepare a PR that
|
See this note in chore posted by you: #6164 (comment) |
so using "docs" works? |
Vía EbookFoundation#6590 Vía EbookFoundation#5762 Recovered from PR EbookFoundation#5752 requested by @reskimulud Co-authored-by: Reski Mulud Muchamad <[email protected]>
@EbookFoundation/reviewers last step. What do you think about this HowTo's homogeneization? Performed Tasks:
It's ok? Aproved to continue apply into the other files? |
- Add H1 header - `Read this` ... right alignmements - Split a bit first paragraph to highlight welcome. - Introduce Pull Request acronym. - trademarks / typos: GitHub, YouTube, Pull Request - Update GitHub links urls. `help`/`guides` subdomain was moved to `docs` so now a 301 Redirect is skipped. - Details block added, with center align. When clicked, the contributor graphs is toggled. - Some bolds to highlight common resources formating issues (like in CONTRIBUTING) - Repo name in monospace font - Re-worded last part of 4th paragraph to explain that no new PR is needed to open if there are linter errors or changes are requested. Now it's more clear, I thought. Via EbookFoundation#6590
I think this looks pretty nice, but unfortunately, you may want to test it in the mobile app. I don't think things like the We could always ignore that technically, since I'd consider that a bug on GitHub's side, though. (Markdown is Markdown, and should work regardless of client.) |
https://davorpa.github.io/free-programming-books/ Tested on a Kindle Fire EReader and a Samsumg S5 (Android 6.1). It works as expected 4x4 in both environments: GitHub Preview, GitHub Pages. In anyway, the previous link "large, growing" points to same graph |
Just checking, you tested in the GitHub Mobile App? |
yes. it works as well.
|
on the whole, I think this looks great. |
docs/README.md
#6698Local branch
Reintegrate stalled conflictive added CONTRIBUTING.md in Indonesian (CONTRIBUTING-id.md) #5752 to complete translation. Addressed by: docs(contributing): Merge #5816 with #5752 Indonesian translation #6719The text was updated successfully, but these errors were encountered: