Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public (early) alpha of free-programming-books search #6643

Closed
eshellman opened this issue Dec 15, 2021 · 7 comments
Closed

Public (early) alpha of free-programming-books search #6643

eshellman opened this issue Dec 15, 2021 · 7 comments

Comments

@eshellman
Copy link
Collaborator

eshellman commented Dec 15, 2021

https://4dylanregan.github.io/myapp/

you can leave comments and suggestions here.

There's a parser that converts the markdown to json,
and a react app that loads the json and searches it.

by @4dylanregan @nrfq @brogan20 @dpekata @LeoOuyang24 @pkelly10439594

@fake-rookie
Copy link

fake-rookie commented Dec 15, 2021

Thans for that first.

A suggestion : maybe not use "button" in results page. use "a" to show the results.

@davorpa
Copy link
Member

davorpa commented Dec 27, 2021

Nice work team!!! @4dylanregan @nrfq @brogan20 @dpekata @LeoOuyang24 @pkelly10439594

Pinned 😉

@davorpa
Copy link
Member

davorpa commented Dec 27, 2021

it would be great have yml format to address frontend using github pages in case of the new app doesn't replace it

Having a JSON should be easier convert it to YML format

@davorpa davorpa pinned this issue Dec 27, 2021
@davorpa
Copy link
Member

davorpa commented Dec 27, 2021

My 2 cents to UI...

It would be great considere responsive design.

Screenshot_20211227-175831

Eg. above screenshot shows irregular gaps when box lines break if content is irregular

POSIBLE SOLUTION: adopt flexbox or grid layout systems

@AhmedElTabarani
Copy link
Contributor

This link: https://4dylanregan.github.io/myapp/ show a blank page, there is no UI at all.
this is normal? or I use the link as API or there something I miss?

@davorpa
Copy link
Member

davorpa commented Feb 15, 2022

This link: 4dylanregan.github.io/myapp show a blank page, there is no UI at all. this is normal? or I use the link as API or there something I miss?

@AhmedElTabarani the project was transfered to the organization recently. Try with

https://ebookfoundation.github.io/free-programming-books-search/

@davorpa davorpa unpinned this issue Feb 23, 2022
@eshellman
Copy link
Collaborator Author

deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants