-
-
Notifications
You must be signed in to change notification settings - Fork 62.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The 0-MOOC and Algorithms and Data Structures anchor tags not working #6508
Comments
I can solve this issue. |
Corrected hrefs of 0-MOOC and Algorithms and Data Structures according to their ids EbookFoundation#6508
It works well on markdown files. @charlottetan more issues with GFM - Kramdown |
@davorpa bummer that parsing continues to be an issue! I spent some time investigating and have two options available: 1. PR #6677 - We switch the parser back to Kramdown (recommended)We originally switched to GFM in PR #5810, before we realised we could use I have my github pages pointed to the branch for this PR and the pages can be viewed here:
And this also results in the anchor tags working: 2. PR #6678 - We modify the anchor tags and set them via HTMLWhen headings include special characters, instead of writing
We do this instead
I don't like this approach as much, like you point out in https://github.com/EbookFoundation/free-programming-books/pull/6678/files#r790243208, this requires a lot of extra effort to make sure it's always right. On top of that, there are many files we'd have to go through to change this in. Also sounds like it might not play well with the new search #6643. Results here: |
Thanks for your valuable hard work 🤟 !!!
At this moment the second is discarded, I thought, due to the reason we post in #6678 (comment) related with #6643. What do you think @EbookFoundation/reviewers ? |
Yeah I think we should go with PR #6677. I also see more discussion in that PR on other possible permutations of the processor |
have asked to folks working on the search to comment. Thanks @charlottetan for looking at this. |
@charlottetan Seems to be consensus on #6677 Ready to merge? |
On clicking 0-MOOC and Algorithms and Data Structures on the webpage, we cannot jump to the respective sections on the page. This feature is not working only for these 2 links.
The text was updated successfully, but these errors were encountered: