Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed React and react native contents #11581

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

manvith12
Copy link
Contributor

@manvith12 manvith12 commented Oct 16, 2024

What does this PR do?

Add resource(s) | Remove resource(s)
resolves issue #11570

For resources

removed "react tutorial" from the subheading "react native" and instead added it under "react"

It is valuable because it maintains the order and subheadings

How do we know it's really free?

it is

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

courses/free-courses-en.md Outdated Show resolved Hide resolved
courses/free-courses-en.md Outdated Show resolved Hide resolved
Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-en.md
1114:1-1147:108  warning  Alphabetical ordering: swap l.1138 and l.1137  alphabetize-lists  remark-lint

@github-actions github-actions bot added the linter error Please, correct build errors found by linter! label Oct 16, 2024
Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-en.md
1114:1-1147:108  warning  Alphabetical ordering: swap l.1139 and l.1138  alphabetize-lists  remark-lint

Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-en.md
1114:1-1146:108  warning  Alphabetical ordering: swap l.1143 and l.1142  alphabetize-lists  remark-lint

Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-en.md
1114:1-1146:108  warning  Alphabetical ordering: swap l.1142 and l.1141  alphabetize-lists  remark-lint

@github-actions github-actions bot removed the linter error Please, correct build errors found by linter! label Oct 16, 2024
@manvith12
Copy link
Contributor Author

lint satisfied successfully uff

@eshellman
Copy link
Collaborator

why not move it to the React section?

@eshellman eshellman added the question Needs clarification by involved users / reviewers label Oct 16, 2024
@manvith12
Copy link
Contributor Author

why not move it to the React section?
there was a existing section named react native , should i remove the section and merge both react and react native?

@eshellman
Copy link
Collaborator

why not move it to the React section?
there was a existing section named react native , should i remove the section and merge both react and react native?

My understanding was that you think a React resource doesn't belong in the React Native section. Fine, so move it to the React section.

@manvith12
Copy link
Contributor Author

manvith12 commented Oct 18, 2024

why not move it to the React section?
there was a existing section named react native , should i remove the section and merge both react and react native?

My understanding was that you think a React resource doesn't belong in the React Native section. Fine, so move it to the React section.

completed

@eshellman
Copy link
Collaborator

it's not added

@github-actions github-actions bot added the conflicts Conflict(s) need to be resolved label Oct 28, 2024
Copy link

Oh no 😟! Conflicts have been found.

Please 🙏, take a moment and address the merge conflicts of your pull request before we can evaluate it again.

Thanks in advance for your effort and patience ❤️!

@github-actions github-actions bot removed the conflicts Conflict(s) need to be resolved label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Needs clarification by involved users / reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants