Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover "Adds express js crash course" #5055 #5503

Conversation

davorpa
Copy link
Member

@davorpa davorpa commented Aug 28, 2021

What does this PR do?

Add resource(s) | Add info | Improve repo

For resources

Description

Pull request at #5055 made by @alok8bb has a stale state and with head/repository deleted.

Resolving conflicts due to repo reorganization made on Dec 2020 (#5199).

So @eshellman I made the review and apply suggestions here.

Why is this valuable (or not)?

Resolves #5055, Closes #5055, Lock #5055

How do we know it's really free?

Follow original PR

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

Followup

  • Check the output of Travis-CI for linter errors!

alok8bb and others added 4 commits November 3, 2020 12:32
Added ExpressJS
Bumps review EbookFoundation#5055

Recover deleted PR head:
git fetch upstream pull/5055/head:pr/alok-cmd/5055-adds-express-js-crash-course

Co-authored-by: alok-cmd <[email protected]>
@davorpa davorpa marked this pull request as ready for review August 28, 2021 17:38
@eshellman
Copy link
Collaborator

For youtube, we prefer "playlist" links and the name of the producer/creator.

@davorpa
Copy link
Member Author

davorpa commented Aug 29, 2021

For youtube, we prefer "playlist" links and the name of the producer/creator.

  • Attributtion was changed in this commit 6ab0aee
  • At least the video is 1h. I have not been able to find a playlist by that author, so if it is not acceptable I think it is better to close both PRs.

@eshellman eshellman merged commit 7f4b7aa into EbookFoundation:master Aug 29, 2021
@davorpa davorpa deleted the pr/alok-cmd/5055-adds-express-js-crash-course branch October 14, 2021 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants