Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update free-courses-en.md #6778

Merged
merged 5 commits into from
Mar 16, 2022
Merged

Update free-courses-en.md #6778

merged 5 commits into from
Mar 16, 2022

Conversation

chalakjeevan
Copy link
Contributor

Angular 5 course added

What does this PR do?

Add resource(s)

For resources

Description

Angular 5 course

Why is this valuable (or not)?

Free course from Udemi

How do we know it's really free?

From udemi description

For book lists, is it a book? For course lists, is it a course? etc.

course

Checklist:

  • [☑] Read our contributing guidelines
  • [☑] Search for duplicates.
  • [☑] Include author(s) and platform where appropriate.
  • [☑] Put lists in alphabetical order, correct spacing.
  • [☑] Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa davorpa added linter error Please, correct build errors found by linter! 🗣️ locale:en Resources addressing "English" language labels Mar 15, 2022
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize to solve linter faults and fix Udemy typo

courses/free-courses-en.md Outdated Show resolved Hide resolved
@davorpa davorpa added the waiting for changes PR has been reviewed and changes/suggestions requested label Mar 15, 2022
@davorpa davorpa removed the waiting for changes PR has been reviewed and changes/suggestions requested label Mar 16, 2022
@davorpa davorpa self-requested a review March 16, 2022 19:39
@davorpa davorpa removed the linter error Please, correct build errors found by linter! label Mar 16, 2022
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are an Instructor name typo

courses/free-courses-en.md Outdated Show resolved Hide resolved
@davorpa davorpa self-requested a review March 16, 2022 19:42
@davorpa davorpa added the 🚀 ready to merge LGTM. Waiting for final approval label Mar 16, 2022
@eshellman
Copy link
Collaborator

Thanks, and welcome to free-programming-books!

@eshellman eshellman merged commit 7d79980 into EbookFoundation:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:en Resources addressing "English" language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants