Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add five books and create two sections #6845

Merged
merged 10 commits into from
Jun 18, 2022

Conversation

Jamil-Bailony
Copy link
Contributor

@Jamil-Bailony Jamil-Bailony commented May 19, 2022

What does this PR do?

Add resource(s)
Fix direction for some phrases that mix Arabic with English by adding RLM (Right-to-Left Mark).

For resources

Description

Add five new books in the Arabic list and create two new sections

How do we know it's really free?

They are all licensed under CC BY-NC-SA.

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@LuigiImVector LuigiImVector added waiting for changes PR has been reviewed and changes/suggestions requested 👀 Needs Review Is this really a good resource? Reviews requested. 🗣️ locale:ar Resources addressing "Arabic / العربية" language labels May 20, 2022
Copy link
Collaborator

@eshellman eshellman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at #6701 and #6715 for hints on how to manage rtl in markdown

books/free-programming-books-ar.md Outdated Show resolved Hide resolved
books/free-programming-books-ar.md Outdated Show resolved Hide resolved
books/free-programming-books-ar.md Outdated Show resolved Hide resolved
books/free-programming-books-ar.md Outdated Show resolved Hide resolved
books/free-programming-books-ar.md Outdated Show resolved Hide resolved
books/free-programming-books-ar.md Outdated Show resolved Hide resolved
books/free-programming-books-ar.md Outdated Show resolved Hide resolved
@Jamil-Bailony Jamil-Bailony requested a review from eshellman June 4, 2022 10:55
Copy link
Member

@LuigiImVector LuigiImVector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #6715 the ‏ is written inside the brackets ([Text]), not after the author's name.
I think you need to copy from there.

@Jamil-Bailony
Copy link
Contributor Author

Jamil-Bailony commented Jun 7, 2022

In #6715 the ‏ is written inside the brackets ([Text]), not after the author's name.
I think you need to copy from there.

Hi @LuigiImVector
Actually, no, I checked it. I know how to write these characters as I am an editor, translator, and programmer. I added them where they are to change the direction inside the phrases that contain English (LTR) and Arabic (RTL).

This is before:
image
This is after:
image

@eshellman
Copy link
Collaborator

We need to insert the rtl/ltr markup in a uniform way for the whole list. It looks to me like the suggestion of @LuigiImVector adds these entries in the same way other entries have been done.

If this is wrong, we need to revise the arabic and hebrew listings. Please discuss this revision in a new issue, so that we can gather expertise from the community and get it right.

For the current PR, please copy the style of markup currently used in other entries in the lists.

Note also that our lists get parsed for searching and the effect of rtl/ltr markup may affect that parsing.

@LuigiImVector
Copy link
Member

LuigiImVector commented Jun 9, 2022

Maybe @AhmedElTabarani can help us

@AhmedElTabarani
Copy link
Contributor

Maybe @AhmedElTabarani can help us

I will glad to help you, but I am busy now for two weeks
mention me on any issue and i will look at it later

@Jamil-Bailony
Copy link
Contributor Author

Hi @eshellman and @LuigiImVector
I checked #6715 again and I can confirm that I am following the same steps in adding RLM (I removed the spaces before RLM in last commit as @AhmedElTabarani did), look at line 308 for example:
image
Here is mine to see the difference:
image
It's not inside brackets as they belong to links not related to RLM.

Can you check again please and let me know if there is still any issues.

books/free-programming-books-ar.md Outdated Show resolved Hide resolved


### <a id="csharp"></a>C#&lrm;

* [سبيلك المختصر لتعلم لغة c#&lrm; - برمجة الواجهات](https://www.mobarmijoun.com/2014/04/c_19.html) - Khaled Al-Saadani (Arab Coders Academy) (PDF)
* [سبيلك المختصر لتعلم لغة c#&lrm; - برمجة الواجهات](https://www.mobarmijoun.com/2014/04/c_19.html) - Khaled Al-Saadani&rlm; (PDF)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [سبيلك المختصر لتعلم لغة c#&lrm; - برمجة الواجهات](https://www.mobarmijoun.com/2014/04/c_19.html) - Khaled Al-Saadani&rlm; (PDF)
* [سبيلك المختصر لتعلم لغة c#&lrm; - برمجة الواجهات](https://www.mobarmijoun.com/2014/04/c_19.html) - Khaled Al-Saadani&rlm; (PDF)

After the &lrm; should go &rlm;?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LuigiImVector
No, as each mark can affect the character direction where it's been added just. In that case for example, the first lrm will affect on the # char just, so it will be c# rather than #c when added in RTL script.
You may have difficulties understanding these characters if you are not in touch with right-to-left languages such as Arabic.

Copy link
Contributor

@AhmedElTabarani AhmedElTabarani Jun 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to make it as "#C" instead of "C#"?
i don't think this is right, because "C#" is a name and the symbol "#" is a part of this name, you can't right it as "#C"

You write it as English so you must Keep it like this "C#" Not this "#C"

Copy link
Member

@LuigiImVector LuigiImVector Jun 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may have difficulties understanding these characters if you are not in touch with right-to-left languages such as Arabic.

Yes, that's why I asked, I was a confused ahahha

If that is right then it is ready to be merged.

books/free-programming-books-ar.md Outdated Show resolved Hide resolved
@LuigiImVector LuigiImVector removed waiting for changes PR has been reviewed and changes/suggestions requested 👀 Needs Review Is this really a good resource? Reviews requested. labels Jun 18, 2022
@LuigiImVector LuigiImVector added the 🚀 ready to merge LGTM. Waiting for final approval label Jun 18, 2022
@eshellman
Copy link
Collaborator

Thanks @Jamil-Bailony, and welcome to free-programming-books! And to everyone for helping.

@eshellman eshellman merged commit a54738a into EbookFoundation:main Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:ar Resources addressing "Arabic / العربية" language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants