-
-
Notifications
You must be signed in to change notification settings - Fork 62.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add five books and create two sections #6845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #6715 the ‏
is written inside the brackets ([Text]
), not after the author's name.
I think you need to copy from there.
Hi @LuigiImVector |
We need to insert the rtl/ltr markup in a uniform way for the whole list. It looks to me like the suggestion of @LuigiImVector adds these entries in the same way other entries have been done. If this is wrong, we need to revise the arabic and hebrew listings. Please discuss this revision in a new issue, so that we can gather expertise from the community and get it right. For the current PR, please copy the style of markup currently used in other entries in the lists. Note also that our lists get parsed for searching and the effect of rtl/ltr markup may affect that parsing. |
Maybe @AhmedElTabarani can help us |
I will glad to help you, but I am busy now for two weeks |
Hi @eshellman and @LuigiImVector Can you check again please and let me know if there is still any issues. |
|
||
|
||
### <a id="csharp"></a>C#‎ | ||
|
||
* [سبيلك المختصر لتعلم لغة c#‎ - برمجة الواجهات](https://www.mobarmijoun.com/2014/04/c_19.html) - Khaled Al-Saadani (Arab Coders Academy) (PDF) | ||
* [سبيلك المختصر لتعلم لغة c#‎ - برمجة الواجهات](https://www.mobarmijoun.com/2014/04/c_19.html) - Khaled Al-Saadani‏ (PDF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [سبيلك المختصر لتعلم لغة c#‎ - برمجة الواجهات](https://www.mobarmijoun.com/2014/04/c_19.html) - Khaled Al-Saadani‏ (PDF) | |
* [سبيلك المختصر لتعلم لغة c#‎ - برمجة الواجهات](https://www.mobarmijoun.com/2014/04/c_19.html) - Khaled Al-Saadani‏ (PDF) |
After the ‎
should go ‏
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LuigiImVector
No, as each mark can affect the character direction where it's been added just. In that case for example, the first lrm will affect on the # char just, so it will be c# rather than #c when added in RTL script.
You may have difficulties understanding these characters if you are not in touch with right-to-left languages such as Arabic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want to make it as "#C" instead of "C#"?
i don't think this is right, because "C#" is a name and the symbol "#" is a part of this name, you can't right it as "#C"
You write it as English so you must Keep it like this "C#" Not this "#C"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may have difficulties understanding these characters if you are not in touch with right-to-left languages such as Arabic.
Yes, that's why I asked, I was a confused ahahha
If that is right then it is ready to be merged.
Thanks @Jamil-Bailony, and welcome to free-programming-books! And to everyone for helping. |
What does this PR do?
Add resource(s)
Fix direction for some phrases that mix Arabic with English by adding RLM (Right-to-Left Mark).
For resources
Description
Add five new books in the Arabic list and create two new sections
How do we know it's really free?
They are all licensed under CC BY-NC-SA.
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:
Follow-up