Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tailwindcsss ,Vue and Svelte structured properly with Learn with Sumit resources #6882

Merged
merged 32 commits into from
Aug 13, 2022
Merged

Add Tailwindcsss ,Vue and Svelte structured properly with Learn with Sumit resources #6882

merged 32 commits into from
Aug 13, 2022

Conversation

yeasin2002
Copy link
Contributor

Added 3 Courses (locale: BN)

Add 10 Bangla Courses | Remove 1 Book Because that website does not exist right now

Bangla resources

Description

Add 10 Bangla Courses

  • Vue.JS
  • Tailwindcsss
  • Svelte

Why is this valuable (or not)?

In Bengal resources, that's not enough, so I added the 2most helpful free resources And

How do we know it's really free?

These resources are from YouTube for its totally free

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

LuigiImVector
LuigiImVector suggested changes Jun 20, 2022
View reviewed changes
courses/free-courses-bn.md Outdated Show resolved Hide resolved
courses/free-courses-bn.md Outdated Show resolved Hide resolved
courses/free-courses-bn.md Outdated Show resolved Hide resolved
@LuigiImVector LuigiImVector added waiting for changes PR has been reviewed and changes/suggestions requested 🗣️ locale:bn Resources addressing "Bengali / বাংলা" language labels Jun 20, 2022
@yeasin2002 yeasin2002 requested a review from LuigiImVector June 20, 2022 18:23
@yeasin2002
Copy link
Contributor Author

That's his channel's Name!

Still, do I need to change the Name?

@eshellman
Copy link
Collaborator

This is a judgment call. We could use "Learn With Sumit" or "Sumit Saha". Depends on how the creator uses the name. If for example, emails from the creator are signed "Learn with Sumit", then that's an indication of how the creator wants to be identified, especially if "Learn With Sumit" is more than just Sumit. If all the videos start with "Hello I'm Sumit Suha", then clearly the creator is "Sumit Suha". If a user needs to work to discover the "Suha" part, then "Learn with Sumit" more clearly identifies the creator for potential students. I doubt the verbose "Learn with Sumit - LWS - Bangladesh" is an appropriate thing to list as the creator. So @mdkawsarislam2002 please consider the suggestions and use the phrase that you think best identifies the creator, and thank you for bearing with us!

@yeasin2002
Copy link
Contributor Author

Thanks.
Now it's ok, I think?

@LuigiImVector
Copy link
Member

Checking the CONTRIBUTING file

free-programming-books/docs/CONTRIBUTING.md

Line 163 in a7558f5

- We don't permit shortened URLs.

and course listings there are no short youtube links (youtu.be)
I think it could be discussed whether to accept official short links or not.

@LuigiImVector LuigiImVector added the 👥 discussion This Repo is guided by its community! Let's talk! label Jun 21, 2022
eshellman
eshellman requested changes Jun 21, 2022
View reviewed changes
courses/free-courses-bn.md Outdated Show resolved Hide resolved
courses/free-courses-bn.md Outdated Show resolved Hide resolved
@yeasin2002 yeasin2002 requested a review from eshellman June 21, 2022 15:14
@LuigiImVector LuigiImVector added 🚀 ready to merge LGTM. Waiting for final approval and removed waiting for changes PR has been reviewed and changes/suggestions requested 👥 discussion This Repo is guided by its community! Let's talk! labels Jun 21, 2022
eshellman
eshellman requested changes Jun 21, 2022
View reviewed changes
courses/free-courses-bn.md Outdated Show resolved Hide resolved
courses/free-courses-bn.md Outdated Show resolved Hide resolved
@davorpa davorpa added the conflicts Conflict(s) need to be resolved label Aug 12, 2022
@davorpa
Copy link
Member

davorpa commented Aug 12, 2022

Conflicts are with indentation made in #6988 merge

@davorpa davorpa self-assigned this Aug 12, 2022
@davorpa davorpa self-requested a review August 12, 2022 15:35
@davorpa davorpa removed the conflicts Conflict(s) need to be resolved label Aug 12, 2022
@davorpa
Copy link
Member

davorpa commented Aug 12, 2022 •
edited
Loading

Some initial Vue & Svelte was lost. Maybe due to some bad merge in commits. I'll review it later as last step previous to merge this PR

@davorpa davorpa added the stale Requests that have not had recent interaction (Out-of-Date) label Aug 12, 2022
davorpa
davorpa reviewed Aug 12, 2022
View reviewed changes
courses/free-courses-bn.md Outdated Show resolved Hide resolved
@davorpa davorpa changed the title Added Tailwindcsss ,Vue and Svelte structured properly Add Tailwindcsss ,Vue and Svelte structured properly with Learn with Sumit resources Aug 12, 2022
@davorpa
Copy link
Member

davorpa commented Aug 12, 2022 •
edited
Loading

Some initial Vue & Svelte was lost. Maybe due to some bad merge in commits. I'll review it later as last step previous to merge this PR

This resources was removed due to be videos or playlists haven't the minimum length of 1h

@davorpa davorpa added waiting for changes PR has been reviewed and changes/suggestions requested 🚀 ready to merge LGTM. Waiting for final approval and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Aug 12, 2022
@davorpa davorpa self-requested a review August 12, 2022 17:16
davorpa
davorpa approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review chop is enough for me

LuigiImVector
LuigiImVector approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@LuigiImVector LuigiImVector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eshellman eshellman merged commit a59b06b into EbookFoundation:main Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuigiImVector LuigiImVector LuigiImVector approved these changes

@davorpa davorpa davorpa approved these changes

@eshellman eshellman Awaiting requested review from eshellman

Assignees

@davorpa davorpa

@yeasin2002 yeasin2002

Labels
🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:bn Resources addressing "Bengali / বাংলা" language stale Requests that have not had recent interaction (Out-of-Date)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yeasin2002 @eshellman @LuigiImVector @davorpa