Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update free-programming-books-tr.md #7063

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Update free-programming-books-tr.md #7063

merged 3 commits into from
Sep 9, 2022

Conversation

emraher
Copy link
Contributor

@emraher emraher commented Sep 8, 2022

r4ds cevirisi eklendi

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@eshellman
Copy link
Collaborator

good addition, but be sure to check the free-programming-books-lint output for linter errors. Alphabetical order and spacing are the most common problems.

@eshellman eshellman added the linter error Please, correct build errors found by linter! label Sep 8, 2022
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Eric requests...

books/free-programming-books-tr.md Outdated Show resolved Hide resolved
@davorpa davorpa added the waiting for changes PR has been reviewed and changes/suggestions requested label Sep 8, 2022
@davorpa davorpa added 🗣️ locale:tr Resources addressing "Turkish / Türkçe" language and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Sep 9, 2022
@davorpa davorpa self-requested a review September 9, 2022 06:53
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Well seen this ending slash 🚀 4874524

@davorpa davorpa added 🚀 ready to merge LGTM. Waiting for final approval and removed linter error Please, correct build errors found by linter! labels Sep 9, 2022
@eshellman eshellman merged commit 4121b20 into EbookFoundation:main Sep 9, 2022
@emraher emraher deleted the patch-1 branch September 14, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:tr Resources addressing "Turkish / Türkçe" language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants