Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update free-courses-en.md #8332

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Update free-courses-en.md #8332

merged 3 commits into from
Nov 8, 2022

Conversation

PriyanshuSahani
Copy link
Contributor

Added A python programming course

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo
Add resource

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@PriyanshuSahani
Update free-courses-en.md
f7a9168 
Added A python programming course
@eshellman eshellman added the conflicts Conflict(s) need to be resolved label Oct 15, 2022
@eshellman eshellman removed the conflicts Conflict(s) need to be resolved label Oct 15, 2022
@eshellman
Copy link
Collaborator

Why did you remove the Mosh course?

@eshellman eshellman added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 15, 2022
@PriyanshuSahani
Update free-courses-en.md
79b375a 
Added back the Programming with Mosh course of Python
PriyanshuSahani
PriyanshuSahani commented Oct 15, 2022
View reviewed changes
Copy link
Contributor Author

@PriyanshuSahani PriyanshuSahani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two courses were added at the same line.
Added both courses one at a time to avoid conflict.

PriyanshuSahani
PriyanshuSahani commented Oct 16, 2022
View reviewed changes
Copy link
Contributor Author

@PriyanshuSahani PriyanshuSahani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Check URLs from changed files / check-urls (pull_request)" test was cancelled earlier. What sould I do?

@eshellman eshellman added changes made Submitter has responded to request for changes and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Nov 8, 2022
@eshellman eshellman merged commit e76922a into EbookFoundation:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changes made Submitter has responded to request for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PriyanshuSahani @eshellman