Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add catalan data structures book #8567

Merged
merged 9 commits into from
Nov 11, 2022

Conversation

Pablito2020
Copy link
Contributor

@Pablito2020 Pablito2020 commented Oct 17, 2022

What does this PR do?

Add resource(s)

For resources

Description

This pull request adds a book about datastructures and algorithms created by some professors of the University of Lleida.

Why is this valuable (or not)?

Could be valuable for people trying to understand some data structures like graphs, linkedlists, etc and they want a book about this topic that is written in catalan.

How do we know it's really free?

It is licensed behind a Creative Commons license, which has:
Attribution, Non commercial and no derivatives.

For book lists, is it a book? For course lists, is it a course? etc.

This is a book (has an ISBN: 978-84-9144-101-4)

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

@Pablito2020
Copy link
Contributor Author

I am participating on HacktoberFest, so I would like to have the "Hacktoberfest-accepted" label if it is possible 😄 .

@eshellman
Copy link
Collaborator

language code is ca.
You want TWO index headings for one resource?
It's usually not helpful to add a category for a single resource. Try to find another category, or see if there are other books in our lists that would fit into your category.

@eshellman eshellman added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 18, 2022
@Pablito2020
Copy link
Contributor Author

Hi @eshellman! The commit 5d51b3d fixes the issues you commented in the pull request review 😃 .

The two books I've added one is a book-wiki about C, and the other is licensed with a creative commons with non commercial derivatives.

Cheers!

@Pablito2020
Copy link
Contributor Author

Some maintainer will review again this pull request? 7 days have passed and the project is accepting other pull requests. Should I change something more?

@eshellman
Copy link
Collaborator

you have not fixed the language code. it should be ca, not es_CA

@eshellman eshellman added the 🗣️ translations Issues or PRs addresing translations label Nov 1, 2022
@eshellman
Copy link
Collaborator

see #9109

README.md Outdated Show resolved Hide resolved
@eshellman eshellman added changes made Submitter has responded to request for changes and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Nov 11, 2022
@eshellman eshellman merged commit 30a6eb9 into EbookFoundation:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes made Submitter has responded to request for changes 🗣️ translations Issues or PRs addresing translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants