Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add javascript course to Romanian books #9025

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

Aquaryus01
Copy link
Contributor

What does this PR do?

Add resource

For resources

Javascript course

Description

Add some Romanian javascript course in the Romanian books sections

Why is this valuable (or not)?

It contains the basic stuff in Javascript

How do we know it's really free?

You can access the website and no pay is needed.

For book lists, is it a book? For course lists, is it a course? etc.

It's a course

Checklist:

  • [ X] Read our contributing guidelines.
  • [ X] Search for duplicates.
  • [ X] Include author(s) and platform where appropriate.
  • [ X] Put lists in alphabetical order, correct spacing.
  • [ X] Add needed indications (PDF, access notes, under construction).
  • [ X] Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

books/free-programming-books-ro.md Outdated Show resolved Hide resolved
* [Javascript](https://marplo.net/javascript)



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these extra lines


### MySQL

* [MySQL](http://profs.info.uaic.ro/~busaco/teach/courses/net/docs/mysql-ro.pdf) (PDF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we getting all these changes when the content is the same?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, very odd

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps encoding?

books/free-programming-books-ro.md Show resolved Hide resolved
@shrn01 shrn01 added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 28, 2022
@eshellman eshellman added changes made Submitter has responded to request for changes and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Nov 15, 2022
@eshellman eshellman merged commit 269ace5 into EbookFoundation:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes made Submitter has responded to request for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants