Fixed some tests (TopBar tests still needs fixing)

Ecdar · Dec 14, 2023 · 0eaec54 · 0eaec54
1 parent 44c6061
commit 0eaec54
Show file tree

Hide file tree

Showing 5 changed files with 42 additions and 19 deletions.
diff --git a/tests/lib/components/settings/colorSettings.test.ts b/tests/lib/components/settings/colorSettings.test.ts
@@ -1,6 +1,12 @@
 import { test, expect, type Dialog } from "@playwright/test";
 
-test.beforeEach(async ({ page }) => {
+test.beforeEach(async ({ page, browserName }) => {
+	// TODO: remove this check when Firefox and WebKit supports popover: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover#browser_compatibility
+	test.skip(
+		browserName === "firefox" || browserName === "webkit",
+		"Popover not supported yet",
+	);
+
 	await page.goto("/");
 	await page.waitForLoadState();
 	await page.waitForLoadState("load");
@@ -9,10 +15,8 @@ test.beforeEach(async ({ page }) => {
 	await page.waitForLoadState("load");
 	await page.waitForLoadState("domcontentloaded");
 
-	await page.getByRole("button", { name: "Options", exact: true }).hover();
-	await page
-		.getByRole("button", { name: "settings Settings", exact: true })
-		.click();
+	await page.getByRole("button", { name: "Options", exact: true }).click();
+	await page.getByRole("button", { name: "Settings", exact: true }).click();
 });
 
 test("can create valid color", async ({ page }) => {

diff --git a/tests/lib/components/settings/fontSettings.test.ts b/tests/lib/components/settings/fontSettings.test.ts
@@ -2,7 +2,13 @@ import { test, expect, type Dialog } from "@playwright/test";
 
 const testFilesPath = "tests/lib/components/settings/testfiles";
 
-test.beforeEach(async ({ page }) => {
+test.beforeEach(async ({ page, browserName }) => {
+	// TODO: remove this check when Firefox and WebKit supports popover: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover#browser_compatibility
+	test.skip(
+		browserName === "firefox" || browserName === "webkit",
+		"Popover not supported yet",
+	);
+
 	await page.goto("/");
 	await page.waitForLoadState();
 	await page.waitForLoadState("load");
@@ -11,10 +17,8 @@ test.beforeEach(async ({ page }) => {
 	await page.waitForLoadState("load");
 	await page.waitForLoadState("domcontentloaded");
 
-	await page.getByRole("button", { name: "Options", exact: true }).hover();
-	await page
-		.getByRole("button", { name: "settings Settings", exact: true })
-		.click();
+	await page.getByRole("button", { name: "Options", exact: true }).click();
+	await page.getByRole("button", { name: "Settings", exact: true }).click();
 	await page.getByRole("button", { name: "Font", exact: true }).click();
 });
 

diff --git a/tests/lib/components/settings/settings.test.ts b/tests/lib/components/settings/settings.test.ts
@@ -1,6 +1,12 @@
 import { test, expect, type Page, type Locator } from "@playwright/test";
 
-test.beforeEach(async ({ page }) => {
+test.beforeEach(async ({ page, browserName }) => {
+	// TODO: remove this check when Firefox and WebKit supports popover: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover#browser_compatibility
+	test.skip(
+		browserName === "firefox" || browserName === "webkit",
+		"Popover not supported yet",
+	);
+
 	await page.goto("/");
 	await page.waitForLoadState();
 	await page.waitForLoadState("load");
@@ -9,10 +15,8 @@ test.beforeEach(async ({ page }) => {
 	await page.waitForLoadState("load");
 	await page.waitForLoadState("domcontentloaded");
 
-	await page.getByRole("button", { name: "Options", exact: true }).hover();
-	await page
-		.getByRole("button", { name: "settings Settings", exact: true })
-		.click();
+	await page.getByRole("button", { name: "Options", exact: true }).click();
+	await page.getByRole("button", { name: "Settings", exact: true }).click();
 });
 
 async function getTabButtons(page: Page): Promise<Locator[]> {

diff --git a/tests/lib/components/topBar/aboutUI/about.test.ts b/tests/lib/components/topBar/aboutUI/about.test.ts
@@ -1,14 +1,19 @@
 import { test, expect } from "@playwright/test";
 
-test.beforeEach(async ({ page }) => {
+test.beforeEach(async ({ page, browserName }) => {
+	// TODO: remove this check when Firefox and WebKit supports popover: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover#browser_compatibility
+	test.skip(
+		browserName === "firefox" || browserName === "webkit",
+		"Popover not supported yet",
+	);
+
 	await page.goto("/");
 	await page.click("#start-new-project");
 });
 
 test("Navigating to Help, then About", async ({ page }) => {
 	await page.getByRole("button", { name: "Help", exact: true }).click();
-
-	await page.getByRole("button", { name: "error About" }).click();
+	await page.getByRole("button", { name: "About", exact: true }).click();
 
 	const aboutBox = await page
 		.locator("dialog")

diff --git a/tests/lib/components/topBar/topbar.test.ts b/tests/lib/components/topBar/topbar.test.ts
@@ -1,6 +1,12 @@
 import { test, expect } from "@playwright/test";
 
-test.beforeEach(async ({ page }) => {
+test.beforeEach(async ({ page, browserName }) => {
+	// TODO: remove this check when Firefox and WebKit supports popover: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover#browser_compatibility
+	test.skip(
+		browserName === "firefox" || browserName === "webkit",
+		"Popover not supported yet",
+	);
+
 	await page.goto("/");
 	await page.click("#start-new-project");
 });