81 feature frontend for engine configuration group5 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: SolarEarth37 <[email protected]>
This allows for multiple engines to be shown in modal component (Not tested, because it no run on my pc for some reason)
…om/ECDAR-AAU-SW-P5/Ecdar-GUI-Web into 81-feature-frontend-for-engine-configuration-group5
… into 80-Create-class-for-engines-group5
…om/ECDAR-AAU-SW-P5/Ecdar-GUI-Web into 81-feature-frontend-for-engine-configuration-group5
…ttps://github.com/ECDAR-AAU-SW-P5/Ecdar-GUI-Web into 81-feature-frontend-for-engine-configuration-group5
Co-authored-by: SolarEarth37 <[email protected]>
Co-authored-by: SolarEarth37 <[email protected]>
Co-authored-by: tr0ub1eM4k3r <[email protected]>
Added min-width to avoid panel collapse when no engines
…ttps://github.com/ECDAR-AAU-SW-P5/Ecdar-GUI-Web into 81-feature-frontend-for-engine-configuration-group5
…and '81-feature-frontend-for-engine-configuration-group5' of https://github.com/ECDAR-AAU-SW-P5/Ecdar-GUI-Web into 81-feature-frontend-for-engine-configuration-group5
DenFlyvendeGed
dismissed stale reviews from atjn and BaBrixx
should be fixed
atjn
reviewed
Dec 14, 2023
atjn
reviewed
Dec 14, 2023
BaBrixx
previously requested changes
Dec 14, 2023
There was a problem hiding this comment.
Non code related things
-
If you press escape while having the modal open it is not possible to reopen it.
-
It is possible to save invalid information by simply pressing discard instead of save
-
Invalid property value
-
Hard to distinguish between different engines (no divider).
-
Scrollbar needs styling (Becomes invisible when hovering)
-
Alignment
…or-engine-configuration-group5
|
I'm sorry to say, but I'm not very good with the last css :( |
DenFlyvendeGed
dismissed
BaBrixx’s stale review
Everything but scroolbar should be fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81
Changes/Additions: