Implement EXISTS command #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoleStrel
commented
Jan 7, 2025
sugardb/api_generic.go
Outdated
Comment on lines
810
to
811
| // Exists returns the number of keys that exist from the provided list of keys. | ||
| // Note: Duplicate keys in the argument list are only counted once. |
There was a problem hiding this comment.
I made it like this because I wanted to use the existing params.KeysExist function which counts the existence in a dictionary and therefore, eliminates duplicates.
is this fine?
If we want it the same as redis to count the duplicate keys multiple times I would need to add a workaround or create a new function
There was a problem hiding this comment.
@NicoleStrel the closer to the Redis behaviour, the better. So we should count duplicate keys here.
kelvinmwinuka
requested changes
Jan 8, 2025
sugardb/api_generic.go
Outdated
Comment on lines
810
to
811
| // Exists returns the number of keys that exist from the provided list of keys. | ||
| // Note: Duplicate keys in the argument list are only counted once. |
There was a problem hiding this comment.
@NicoleStrel the closer to the Redis behaviour, the better. So we should count duplicate keys here.
kelvinmwinuka
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#158