Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End current session if can't resume #128

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

shalinnijel2
Copy link
Contributor

Summary:
This change follows an issue seen with a real EV where attempting to resume an existing session fails. In this case we were attempting to resume a connection that was reset by the peer.
If resuming a session fails, now we

  • Cancel the existing task associated with it and remove the session entry from self.comm_sessions list.
  • Create a new SECCCommunicationSession and add that to self.comm_sessions list.

@shalinnijel2 shalinnijel2 requested a review from tropxy September 7, 2022 22:50
@shalinnijel2 shalinnijel2 merged commit f953379 into master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants